Improve Quantization Setup Prompts and Doc #1537
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1537
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Cancelled JobsAs of commit 70239cc with merge base 0299a37 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Jack-Khuu
approved these changes
May 2, 2025
| exit 1 | ||
| fi | ||
|
|
||
| if [[ "$LINK_TORCHAO_OPS" == "ON" ]]; then | ||
| if [ ! -d "${TORCHCHAT_ROOT}/torchao-build" ]; then | ||
| echo "Directory ${TORCHCHAT_ROOT}/torchao-build does not exist." | ||
| echo "Make sure you run clone_torchao" | ||
| echo "Make sure you run bash torchchat/utils/scripts/clone_torchao.sh" |
There was a problem hiding this comment.
nit: don't need to specify bash
| @@ -149,6 +149,7 @@ From the torchchat root directory, run | |||
| bash torchchat/utils/scripts/build_torchao_ops.sh | |||
| ``` | |||
|
|
|||
| Note that before running it, you must first clone torchao with `bash torchchat/utils/scripts/clone_torchao.sh` if you have not done so already. | |||
There was a problem hiding this comment.
clone_torchao is called as part of the install_requirements, so it might be better for us to remind users to call that first
|
The ET failure is a separate pin error that I'm throwing up a fix for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't prompt people to clone torchao first before running
bash torchchat/utils/scripts/build_torchao_ops.sh. We can improve the prompts and doc similar to what we already have forbash torchchat/utils/scripts/build_native.sh et link_torchao_ops.cc @Jack-Khuu @byjlw